Alon Bar-Lev has posted comments on this change. Change subject: aaa: Failure to add user name in rest-api due to wrong username ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32481/1/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java: Line 277: Authz.PrincipalRecord.TITLE, Line 278: user.getTitle() Line 279: ).mput( Line 280: Authz.PrincipalRecord.PRINCIPAL, Line 281: removeUpnSuffix(user.getUserName()) > why not remove this at the restapi level? I may understand... you do not support login by full upn? so the principal is really the user name without suffix? Line 282: ); Line 283: if (user.getGroups() != null) { Line 284: List<ExtMap> groups = new ArrayList<>(); Line 285: for (LdapGroup group : user.getGroups().values()) { -- To view, visit http://gerrit.ovirt.org/32481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3354f48ebd1027e2d15675b27811931dcbdbe1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
