Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Make pki interaction easier ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/32385/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py: Line 371: stage=plugin.Stages.STAGE_CLEANUP, Line 372: ) Line 373: def _cleanup(self): Line 374: if self._csr_file is not None: Line 375: if os.path.exists(self._csr_file.name): I would prefer to call os.unlink and then handle the exception if it doesn't exist. Line 376: os.unlink(self._csr_file.name) Line 377: Line 378: http://gerrit.ovirt.org/#/c/32385/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py: Line 276: stage=plugin.Stages.STAGE_CLEANUP, Line 277: ) Line 278: def _cleanup(self): Line 279: if self._csr_file is not None: Line 280: if os.path.exists(self._csr_file.name): same here Line 281: os.unlink(self._csr_file.name) Line 282: Line 283: -- To view, visit http://gerrit.ovirt.org/32385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b3713330d6e11bd7c374e04f17660be79f2251 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
