Roy Golan has posted comments on this change. Change subject: core: VM monitoring - no need to handle exception ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28661/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 177: filterVmsFromMonitoringCycle(); Line 178: Line 179: List<Guid> staleRunningVms = checkVmsStatusChanged(); Line 180: Line 181: proceedWatchdogEvents(); > Why all this noise? what has changed in this code ? don't understand what are you referring exactly fetchRunningVms isn't a boolean method any more. Line 182: Line 183: proceedBalloonCheck(); Line 184: Line 185: proceedDownVms(); -- To view, visit http://gerrit.ovirt.org/28661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f037813b52d63c45c97c44e3e6074c009dd5b9a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
