Arik Hadas has posted comments on this change. Change subject: core: ImportVmCommand storage allocation checks ......................................................................
Patch Set 10: (2 comments) general question that I didn't understand while reviewing this patch, if copy-collapse is used then only the memory volume of the active snapshot should be taken into account and if the VM is imported as cloned no memory volume should be taken into account, is it computed that way? http://gerrit.ovirt.org/#/c/32258/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 104: private static final Log log = LogFactory.getLog(ImportVmCommand.class); Line 105: Line 106: private static VmStatic vmStaticForDefaultValues = new VmStatic(); Line 107: private List<DiskImage> imageList; Line 108: private List<DiskImage> memoryDisksList; not in use? if not, please remove Line 109: Line 110: private final List<String> macsAdded = new ArrayList<String>(); Line 111: private final SnapshotsManager snapshotsManager = new SnapshotsManager(); Line 112: Line 494: updateStorageDomainForMemoryVolumes how about to change 'update' to 'get'? I don't see we update anything here right? -- To view, visit http://gerrit.ovirt.org/32258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
