Martin Sivák has posted comments on this change. Change subject: engine: Improve reporting when scheduling fail on network ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/29790/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java: Line 134 Line 135 Line 136 Line 137 Line 138 > This seems to not be used anymore, please remove it. We have couple of those around, I would like to do the cleanup using a separate patch. Line 184 Line 185 Line 186 Line 187 Line 188 > Same here. See above. Line 192 Line 193 Line 194 Line 195 Line 196 > Same here. See above. Line 183: Line 184: // Check if display network attached to host and has a proper boot protocol Line 185: if (displayNic == null) { Line 186: log.debugFormat("host {0} is missing the cluster's display network", host.getName()); Line 187: return new ValidationResult(VdcBllMessages.VAR__DETAIL__DISPLAY_NETWORK_MISSING); > Maybe supply the network name here as well? We could report the name to the log, but the API currently does not pass the name around. Also there is only one display network isn't it? Line 188: } Line 189: Line 190: if (displayNic.getBootProtocol() == NetworkBootProtocol.NONE) { Line 191: log.debugFormat("Host {0} has the display network {1} configured with improper boot protocol on interface {2}.", -- To view, visit http://gerrit.ovirt.org/29790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic60daf20842ba69457b293f451060e21381faf80 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
