Alona Kaplan has posted comments on this change. Change subject: webadmin: Focus on label widget by default ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32096/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java: Line 23: asSuggestBox().getValueBox().addFocusHandler(new FocusHandler() { Line 24: Line 25: @Override Line 26: public void onFocus(FocusEvent event) { Line 27: Scheduler.get().scheduleDeferred(new ScheduledCommand() { > The deferred command is needed so that the suggestion list is placed in the I guess you should add attach or load event to the suggestBox and not override the ListModelSuggestBox.onLoad() method. If not, you should understand what should happen before placing the suggestBox. Using deferred binding in this case is just an "acamol". As I write in the previous comment, there are scenarios it won't work. Line 28: Line 29: @Override Line 30: public void execute() { Line 31: asSuggestBox().showSuggestionList(); -- To view, visit http://gerrit.ovirt.org/32096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36c9ae0b7ac9d61112ace1829434c9c685b85a22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
