Ayal Baron has posted comments on this change.
Change subject: core: Support diskless snapshots
......................................................................
Patch Set 6: (4 inline comments)
grammar and spelling and typing errors only, nothing substantial
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
Line 84: private void tryBackToVmConfigurationSnapshot() {
this name is illegible.
revertVmToSnapshotConfig?
revertVmConfigBySnapshot?
...
....................................................
Commit Message
Line 15: The code that finilizes the preview was extracted into a method, which
s/finilizes/finalizes/
Line 17: * If the snapshot has disks, it's called from the EndSuccessfully,
after
s/the EndSuccessfully, /EndSuccessfully /
Line 21: ExecuteVmCommand, since there are no async tasks that we're waitig
s/waitig/waiting/
--
To view, visit http://gerrit.ovirt.org/6387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0193a7f4ba0e25ddeaacdf25b6a746d5ce50d698
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
