Eldan Shachar has uploaded a new change for review. Change subject: userportal/webadmin: Remove tooltip from host tab under VM window ......................................................................
userportal/webadmin: Remove tooltip from host tab under VM window Tooltip was removed from "Start Running On" label as it was no longer true. Change-Id: I20c00e560b0f6666f9dcc52e388a23266a102e45 Bug-Url: https://bugzilla.redhat.com/1124432 Signed-off-by: Eldan Shachar <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 3 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/32736/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java index 84be89e..a88f253 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java @@ -1754,9 +1754,6 @@ @DefaultStringValue("FQDN") String fqdn(); - @DefaultStringValue("The fields under 'Start Running On' and 'Migration Options' aren't editable while the VM isn't down") - String nonEditableMigrationFieldsWhileVmNotDownInfo(); - @DefaultStringValue("Active VM") String snapshotDescriptionActiveVm(); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java index 2ccc975..4dd0d47 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java @@ -597,9 +597,6 @@ public Label specificHostLabel; @UiField(provided = true) - public InfoIcon nonEditableWhileVmNotDownInfo; - - @UiField(provided = true) @Path(value = "defaultHost.selectedItem") @WithElementId("defaultHost") public ListModelListBoxEditor<VDS> defaultHostEditor; @@ -896,9 +893,6 @@ .replaceAll("(\r\n|\n)", "<br />")), resources);//$NON-NLS-1$ //$NON-NLS-2$ isVirtioScsiEnabledInfoIcon = new InfoIcon(applicationTemplates.italicText(constants.isVirtioScsiEnabledInfo()), resources); - nonEditableWhileVmNotDownInfo = - new InfoIcon(applicationTemplates.italicText(constants.nonEditableMigrationFieldsWhileVmNotDownInfo()), - resources); final Integer defaultMaximumMigrationDowntime = (Integer) AsyncDataProvider.getInstance().getConfigValuePreConverted(ConfigurationValues.DefaultMaximumMigrationDowntime); migrationDowntimeInfoIcon = new InfoIcon(applicationTemplates.italicText(messages.migrationDowntimeInfo(defaultMaximumMigrationDowntime)), resources); priorityEditor = new EntityModelCellTable<ListModel>( diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml index b9bff79..072c1b1 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml @@ -584,7 +584,6 @@ <t:content> <g:FlowPanel> <g:FlowPanel ui:field="startRunningOnPanel"> - <d:InfoIcon ui:field="nonEditableWhileVmNotDownInfo" addStyleNames="{style.labelToCoupleCoupleLeft} avmpw_infoIcon_pfly_fix"/> <g:Label addStyleNames="{style.sectionLabel}" text="{constants.runOnVmPopup}" /> <g:VerticalPanel addStyleNames="{style.runHostPanel}" verticalAlignment='ALIGN_MIDDLE'> <ge:EntityModelRadioButtonEditor ui:field="isAutoAssignEditor" -- To view, visit http://gerrit.ovirt.org/32736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20c00e560b0f6666f9dcc52e388a23266a102e45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
