Arik Hadas has posted comments on this change. Change subject: core: cleanup AddVmParameters constructors ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32641/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java: Line 14: public AddVmParameters() { Line 15: } Line 16: Line 17: public AddVmParameters(VmStatic vmStatic) { Line 18: super(vmStatic); > please keep the initialization of the diskInfoList, and fix the getter.. Done Line 19: } Line 20: Line 21: public AddVmParameters(VM vm) { Line 22: this(vm.getStaticData()); -- To view, visit http://gerrit.ovirt.org/32641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06f2de3db1b0559af4df04d0d158b10b8460c684 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
