Piotr Kliczewski has posted comments on this change. Change subject: core: monitoring: adhere to fields naming convention ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/27941/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java: Line 60: private static Map<Guid, Long> hostDownTimes = new HashMap<>(); Line 61: private boolean vdsMaintenanceTimeoutOccurred; Line 62: Line 63: private static final Log log = LogFactory.getLog(HostMonitoring.class); Line 64: It would be good to use this when we refer to local instance state. Line 65: public HostMonitoring(VdsManager vdsManager, VDS vds, MonitoringStrategy monitoringStrategy) { Line 66: this.vdsManager = vdsManager; Line 67: this.vds = vds; Line 68: firstStatus = vds.getStatus(); -- To view, visit http://gerrit.ovirt.org/27941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18d520d3b7a61c2e02bb43ca73334b8c0ecc1c23 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
