Roy Golan has posted comments on this change.

Change subject: core: cleanup VdsManager dispose
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/32757/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java:

Line 714: 
Line 715:     public void dispose() {
Line 716:         log.info("vdsManager::disposing");
Line 717:         SchedulerUtilQuartzImpl.getInstance().deleteJob(onTimerJobId);
Line 718:         _vdsProxy.close();
perfect :)
Line 719:     }
Line 720: 
Line 721:     /**
Line 722:      * Log the network exception depending on the VDS status.


-- 
To view, visit http://gerrit.ovirt.org/32757
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I204a60f20a19e79a431c9cb463073d160a5862a4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to