Ravi Nori has posted comments on this change. Change subject: engine: placeholders of child commands aren't cleared when failing during the CDA phase ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32790/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 345: if (actionAllowed) { Line 346: execute(); Line 347: } else { Line 348: getReturnValue().setCanDoAction(false); Line 349: clearChildAsyncTasksWithOutVdsmId(); > Yes, we would like to insert the place holders in a single transaction. If it is in finally it will always be executed. Since execute method has not run at this stage all child commands will have empty vdsm id. So it should only be execute when CDA is false Line 350: } Line 351: } finally { Line 352: freeLockExecute(); Line 353: clearAsyncTasksWithOutVdsmId(); -- To view, visit http://gerrit.ovirt.org/32790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77a00b0071c92d074d837768af012c80374169f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
