Martin Mucha has posted comments on this change. Change subject: core,webadmin: enforce that label cannot be added to external network short summary under 50 chars ......................................................................
Patch Set 1: same problem is true for UnlabelNetworkCommand. I know that external networks cannot have labels, so in ideal worlds where everyone does what should be done, there should not be problem. But another point of view is, that labeling features is restricted to non-external network use only, so neither of these actions should be allowed. Unlabelling should be prohibited upon checks and not upon belief that there cannot exist something to be deleted. So I'd of course opted for stronger checks without relying on another command cooperation. What do you think? Can I add such check also to UnlabelNetworkCommand? -- To view, visit http://gerrit.ovirt.org/32825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c697a06afa15ff5c31c0396d0744c9c456c2dc9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
