Alon Bar-Lev has posted comments on this change. Change subject: tools: Adds helpers to configure java logging in tools ......................................................................
Patch Set 1: (2 comments) I expect removal of the log4j at same patch... :) not sure I understand why we need the same formatter (new class) and we cannot just have a format that uses the simpler formatters. http://gerrit.ovirt.org/#/c/32852/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/JavaLoggingUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/JavaLoggingUtils.java: Line 19: if (configFile == null) { Line 20: // configure default formatter Line 21: System.setProperty( Line 22: "java.util.logging.SimpleFormatter.format", Line 23: "%1$tY-%1$tm-%1$td %1$tH:%1$tM:%1$tS,%1$tL %4$-5s [%2$s] %5$s%6$s%n"); please use embedded logging.properties, it can be within resource as far as I remember, or default within command-line. Line 24: Line 25: // reset config and set level to ALL, so we can set desired level on handler Line 26: LogManager.getLogManager().reset(); Line 27: Logger.getLogger("").setLevel(Level.ALL); Line 48: * INFO INFO Line 49: * WARN WARNING Line 50: * ERROR SEVERE Line 51: * FATAL SEVERE Line 52: * OFF OFF not sure we need mapping at all, just use reflection. Line 53: * Line 54: * @param levelName Line 55: * specified level name Line 56: * @exception java.lang.IllegalArgumentException -- To view, visit http://gerrit.ovirt.org/32852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1c46ca552888b347a4ff810003e0fcc818f832f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
