Juan Hernandez has posted comments on this change. Change subject: build: Add category to module definition ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/32845/1/build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java File build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java: Line 79: /** Line 80: * Category of the module: Line 81: * common - modules that are used inside JBoss instance and in standalone tools Line 82: * instance - modules that are used only inside JBoss instance Line 83: * standalone - modules that are used only in standalone tools The HTML generated for this Javadoc doesn't look good, it puts all in one line. Line 84: */ Line 85: @Parameter(property = "category", defaultValue="common") Line 86: private String category; Line 87: Line 146: File modulesArchive = new File(targetDir, Line 147: String.format( Line 148: "%s-%s-modules.zip", Line 149: project.getBuild().getFinalName(), Line 150: category)); The usual name for maven artifacts is ${artifactId}-${version}-${classifier}.${type}. Here you are introducing a slight variation. I think that Maven won't complain about that currently, but in the future it may ignore the file name and use the properties. So I think it is better if you also change the "classifier" parameter passed to the "attachArtifact" below. Line 151: ZipArchiver modulesArchiver = new ZipArchiver(); Line 152: modulesArchiver.setDestFile(modulesArchive); Line 153: modulesArchiver.addDirectory(modulesDir); Line 154: getLog().info("Creating module archive \"" + modulesArchive + "\""); Line 162: } Line 163: Line 164: // Attach the generated zip file containing the modules as an Line 165: // additional artifact: Line 166: getLog().info("Attaching modules artifact \"" + modulesArchive + "\""); Here, third argument, should be the classifier that you calculated before. Line 167: projectHelper.attachArtifact(project, "zip", "modules", modulesArchive); Line 168: } Line 169: Line 170: private void createModule(Module module) throws MojoExecutionException { -- To view, visit http://gerrit.ovirt.org/32845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6e14398bec4378c2153514bb69667835c3d331 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
