Lior Vernia has posted comments on this change. Change subject: frontend: refactoring: Generify Events and Listeners ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/32837/5//COMMIT_MSG Commit Message: Line 11: Minor adjustments in Event infa: Line 12: Line 13: - Event#registerListener now accepts also contravariant implementations Line 14: of IEventListener (e.g. you can attach an IEventListener<EventArgs> to Line 15: Event<PropertyChangedEventArgs>) This is great! Line 16: Line 17: - Dropped the generic specifcation from the first Event<T> parameter of Line 18: IEventListener#eventRaised method since this parameter, as opposed to Line 19: args, was rarely used and never in generic way (almost exclusively for object Line 18: IEventListener#eventRaised method since this parameter, as opposed to Line 19: args, was rarely used and never in generic way (almost exclusively for object Line 20: equality checks) and the correct form given the above contravariance Line 21: feature would require unnecessary complication of all implementors Line 22: (Event<? extends T>). This I'm not sure I understand. If you had already gone through the trouble of parametrizing all these event arguments everywhere - why not do it right and also parametrize the events? Line 23: Line 24: Along the way there were encountered varios small oportunities to Line 25: generify several entity models and get rid of unnecessary casts. These Line 26: oportunities have been siezed. -- To view, visit http://gerrit.ovirt.org/32837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icddf5780c00c985966e6ae956a401c3ede6a68e7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
