Liron Aravot has posted comments on this change. Change subject: core: remove unneeded call to lock vm in db on import vm ......................................................................
Patch Set 3: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/32378/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 723 Line 724 Line 725 Line 726 Line 727 > yes, it is safe since the VM didn't exist before the import command, so no yes, but now we won't have those properties set. are we fine with that? my point is that this call doesn't just lock the vm. -- To view, visit http://gerrit.ovirt.org/32378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f7d350bf7cd044a7b4ff64e9376963fd5ec9b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
