Omer Frenkel has posted comments on this change. Change subject: core: Fail Add/Update Vm when CPU is unsupported ......................................................................
Patch Set 5: (2 comments) also missing messages files (appErrors.java & props) http://gerrit.ovirt.org/#/c/32926/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 525: getVdsGroup().getcompatibility_version(), Line 526: CpuFlagsManagerHandler.getCpuIdByNameAndVersion( Line 527: getVdsGroup().getcpu_name(), Line 528: getVdsGroup().getcompatibility_version()))) { Line 529: String unsupportedCpus = osRepository.getUnsupportedCpus().get(new Pair<>( why you are not using getUnsupportedCpus(int osId, Version version) ? (you'll need to make it public but i think it would be better, no?) Line 530: vmFromParams.getVmOsId(), Line 531: getVdsGroup().getcompatibility_version())).toString(); Line 532: return failCanDoAction( Line 533: VdcBllMessages.CPU_TYPE_UNSUPPORTED_FOR_THE_GUEST_OS, http://gerrit.ovirt.org/#/c/32926/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java: Line 104: } Line 105: return null; Line 106: } Line 107: Line 108: public static String getCpuIdByNameAndVersion(String cpuName, Version version) { why overload? wouldn't it better to rename the method? Line 109: return GetVDSVerbDataByCpuName(cpuName, version); Line 110: } Line 111: Line 112: private static class CpuFlagsManager { -- To view, visit http://gerrit.ovirt.org/32926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1d22994c59b16d1d71d2315882d41454079bf32 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
