Gilad Chaplik has posted comments on this change. Change subject: engine: NUMA feature transaction support ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/28241/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 932: protected void addVmNumaNodes() { Line 933: List<VmNumaNode> numaNodes = getParameters().getVmStaticData().getvNumaNodeList(); Line 934: VmNumaNodeOperationParameters params = new VmNumaNodeOperationParameters(getVmId(), numaNodes); Line 935: getBackend().runInternalAction(VdcActionType.AddVmNumaNodes, params); Line 936: } had several issues, please refer to http://gerrit.ovirt.org/#/c/32904/ Line 937: Line 938: protected void addVmInit() { Line 939: VmHandler.addVmInitToDB(getParameters().getVmStaticData()); Line 940: } http://gerrit.ovirt.org/#/c/28241/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 607: srcDeviceIdToTargetDeviceIdMapping.put(iface.getId(), iDynamic.getId()); Line 608: } Line 609: } Line 610: Line 611: protected void addVmNumaNodes() { we can remove it from the patch (pushing template support). Line 612: List<VmNumaNode> vmNumaList = DbFacade.getInstance().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(getVmId()); Line 613: if (vmNumaList != null && vmNumaList.size() > 0) { Line 614: List<VmNumaNode> templateList = new ArrayList<>(); Line 615: for (VmNumaNode vnode : vmNumaList) { -- To view, visit http://gerrit.ovirt.org/28241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84e59fa38c9174fe7150116bf3c8832f7fac1dd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jason Liao <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
