Allon Mureinik has posted comments on this change.
Change subject: core:Replace vm id with number of vms in views.
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(5 inline comments)
basically looks good - see inline minor comments
....................................................
File backend/manager/dbscripts/create_functions.sql
Line 279: FROM images_storage_domain_view LEFT OUTER JOIN vm_device ON
vm_device.device_id = images_storage_domain_view.disk_id
minor: put the JOIN in a separate line after the FROM
....................................................
File backend/manager/dbscripts/create_views.sql
Line 22: CREATE OR REPLACE VIEW vm_for_disk_view
minor: s/vm/vms/
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
Line 25: private ArrayList<String> vmNames;
Why not hold this a a List<String>?
Line 37: ArrayList<String> vmNames,
same
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractDiskRowMapper.java
Line 25: : new
ArrayList<String>(Arrays.asList(vmNames.split(","))));
If your setVmNames() will get a List, you won't need the new ArrayList() there
--
To view, visit http://gerrit.ovirt.org/5216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id306d8322245780ea200c10f9e96254cddf3bc76
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
