Liron Aravot has uploaded a new change for review. Change subject: core: fix removal of lun disk with no vm (#841265) ......................................................................
core: fix removal of lun disk with no vm (#841265) https://bugzilla.redhat.com/841265 when trying to delete a lun disk with no vm, NPE was encountered. this patch solves it and is a further fix to patch http://gerrit.ovirt.org/#/c/6505/ added the following TODOs: 1. RemoveDiskCommand class - this command handles at least few different cases of disk removal -it should be separated to different classes that will handle different scenarios 2.buildSharedLockMap() method - there might be a race condition here - the list of vm's is loaded and only afterwards a lock is performed - so we can't be aware to changes in DB to the vms list and may perform the operation on an outdated list 3.EndSuccessfully() method - need to verify that this list of vms cannot differ from the one that was processed on the CanDoAction phase. Change-Id: Iad5a09962da87d9e3f8d06685daf2f64ed751fd3 Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/6566/1 -- To view, visit http://gerrit.ovirt.org/6566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad5a09962da87d9e3f8d06685daf2f64ed751fd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
