Allon Mureinik has posted comments on this change. Change subject: core: Verify that date is initialized in OVF_STORE disk ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/32963/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 344: private Date getDateFromDiskDescription(Map<String, Object> map) { Line 345: try { Line 346: if (map.get(OvfInfoFileConstants.LastUpdated) != null) { Line 347: return new SimpleDateFormat(OvfParser.formatStrFromDiskDescription).parse(map.get(OvfInfoFileConstants.LastUpdated) Line 348: .toString()); "OvfParser.formatStrFromDiskDescription).parse(map.get(Ov fInfoFileConstants.LastUpdated))" is duplicated here - please extract it to a local variable Line 349: } else { Line 350: log.info("LastUpdate Date is not initialized in the OVF_STORE disk."); Line 351: } Line 352: } catch (java.text.ParseException e) { -- To view, visit http://gerrit.ovirt.org/32963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e59086ce7242d7aaec10b57b6775ab968c9fe1c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
