Martin Mucha has posted comments on this change. Change subject: core: add support of variableReplacements to ValidationResultBuilder ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/30662/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java: Line 51: throw new IllegalArgumentException("message must not be null"); Line 52: } Line 53: Line 54: this.message = message; Line 55: this.variableReplacements = variableReplacements == null > I think it would be more readable if written as: Done Line 56: ? null : Line 57: Collections.unmodifiableList(Arrays.asList(variableReplacements)); Line 58: } Line 59: Line 153: * @param expectedError Line 154: * The error we expect should the validation fail. Line 155: * @return A helper object that returns the correct validation result depending on the condition. Line 156: */ Line 157: public static ValidationResultBuilder failWith(VdcBllMessages expectedError, String... variableReplacements) { > Please add Javadoc for the new parameter Done Line 158: return new ValidationResultBuilder(expectedError, variableReplacements); Line 159: } Line 160: Line 161: /** -- To view, visit http://gerrit.ovirt.org/30662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d931b52d97bbac855c17ac13ee3acbda0c0f6fe Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
