Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: ensureColumnPresentFix ......................................................................
Patch Set 2: Code-Review+2 (1 comment) Please see my comment before merging, thanks. http://gerrit.ovirt.org/#/c/32831/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java: Line 221: /** Line 222: * @param column The column to ensure is there. Line 223: * @param headerText The header text associated with the column. Line 224: * @param present If true make sure the column is there, if false make sure it is not. Line 225: * @param width The width of the column. Before merging, to have proper Javadoc, please move these @param declarations below the actual description, i.e. Ensures ... rest of description @param ... (Otherwise, Javadoc will be messed up - @param width will have "Ensures ..." as part of its description.) Line 226: * Ensures that the given column is added (or removed), unless it's already present (or absent). Line 227: * <p> Line 228: * This method also sets the column width in case the column needs to be added. Line 229: */ -- To view, visit http://gerrit.ovirt.org/32831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82f725fd98a1690c16fd01a40fa1c05a27d3237e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
