Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: drag windows
......................................................................
Patch Set 2:
Alright, we could use CSS constants as described in GWT docs for CssResource
[1]:
// DialogBox.css
@def one 1;
.gwt-DialogBox .Caption {
z-index: one;
}
[1] http://www.gwtproject.org/doc/latest/DevGuideClientBundle.html#CssResource
We could create some CSS file to hold all constants, for example:
gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/Constants.css
// Constants.css
@def one 1;
Unfortunately, GWT compiler doesn't seem to support CSS @import declaration [2].
[2]
http://stackoverflow.com/questions/2641747/gwt-problems-with-constants-in-css
So we need a bit of Java to assist us:
0, create CssConstants (optional)
package org.ovirt.engine.ui.common;
public interface CssConstants extends CssResource {
int one(); // we can omit this if we want
}
1, in CommonApplicationResources
static final String CONSTANTS_CSS = "css/Constants.css";
// optional, only if we want access to CSS constants from within Java code
@Source(CONSTANTS_CSS)
CssConstants constantsStyle();
@Source(CONSTANTS_CSS, "css/DialogBox.css")
CssResource dialogBoxStyle();
2, in DialogBox.css
.gwt-DialogBox .Caption {
z-index: one;
}
3, within <ui:style> of given UiBinder template
<ui:style src="org/ovirt/engine/ui/common/css/Constants.css" />
--
To view, visit http://gerrit.ovirt.org/32860
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee527761196d9a43a3eef003f60e2063e04d9d9c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
