Omer Frenkel has posted comments on this change. Change subject: core: Lazy load of Vms per VDS ......................................................................
Patch Set 3: (1 comment) adding Roy, not sure this is relevant with the changes are right now being pushed for vurti http://gerrit.ovirt.org/#/c/32669/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1834: * Line 1835: * @param staleRunningVms - VMs that didn't change their status Line 1836: */ Line 1837: private void removeVmsFromCache(List<Guid> staleRunningVms) { Line 1838: if (_vds.getVmCount() > 0) { _vds.getVmCount() does not correlate the vmDict, please dont add this if also this method is called from within updateRepository method that already did getVmDict() so it is already loaded, no reason to take a risk Line 1839: for (VM vmToRemove : getVmDict().values()) { Line 1840: if (staleRunningVms.contains(vmToRemove.getId())) { Line 1841: continue; Line 1842: } -- To view, visit http://gerrit.ovirt.org/32669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic61f8d965083b814b64257831a2ed3c6d7f764c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
