Daniel Erez has posted comments on this change. Change subject: webadmin, core: Return specific provider authentication error ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/31179/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java: Line 430: Line 431: private void setTestResultValue(VdcReturnValueBase result) { Line 432: String errorMessage = EMPTY_ERROR_MESSAGE; Line 433: if (result == null || !result.getSucceeded()) { Line 434: if (result != null) { relevant to this patch? Line 435: errorMessage = Frontend.getInstance().translateVdcFault(result.getFault()); Line 436: } else if ((Boolean) requiresAuthentication.getEntity() && StringHelper.isNullOrEmpty(keystoneUrl)) { Line 437: errorMessage = ConstantsManager.getInstance().getConstants().noAuthUrl(); Line 438: } else { -- To view, visit http://gerrit.ovirt.org/31179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d6540b115454cfd2aa055ba711694f74855164 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
