Vojtech Szocs has posted comments on this change.

Change subject: userportal,webadmin: persistent column widths
......................................................................


Patch Set 5:

> Hmm okay well the generated ids do change between compiles.

If you mean IDs generated using

 DOM.createUniqueId()

then such ID values depend on order in which different components call above 
method.

You can see that in Document#createUniqueId implementation - code adds 
"gwt_uid" property to "document" object (representing the whole DOM).

We should ensure that IdHandler framework is properly utilized to have stable 
and predictable element IDs.

-- 
To view, visit http://gerrit.ovirt.org/32146
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36fa590ee3521782e01160ee09575e3848912f9d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to