Dan Kenigsberg has posted comments on this change. Change subject: engine: Add validation that display network is required ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/32906/2//COMMIT_MSG Commit Message: Line 6: Line 7: engine: Add validation that display network is required Line 8: Line 9: Previously the display network was de-facto treated as required, now Line 10: added this as explicit validation. I do not think that this is the case: if the nic of a display network looses its carriage, the network goes down. But if the network is define as non-required, VMs that use it should not be migrated away. Line 11: Line 12: Also made sure existing display network are marked as required using Line 13: an upgrade script, so that we can maintain a consistent state where Line 14: display networks are from now on necessarily required. -- To view, visit http://gerrit.ovirt.org/32906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ca7c7ca3084d2dec6690bf60e7fa7fd7efc319c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
