Roy Golan has posted comments on this change. Change subject: core: monitoring - separate Host Monitoring and Vm Moniting ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/28173/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 134: this.vmDict = getDbFacade().getVmDao().getAllRunningByVds(vds.getId()); Line 135: vmManagers = new HashMap<>(vmDict.size()); // max size is the one's that in the db Line 136: } Line 137: Line 138: public void begin() { > It looks like it is performMonitoring method or something similar. will change to perform Line 139: try { Line 140: lockVmsManager(); Line 141: refreshVmStats(); Line 142: saveVmsToDb(); Line 222: for (Guid vmId : runningVms.keySet()) { Line 223: if (!vmManagers.containsKey(vmId)) { Line 224: runningVms.remove(vmId); Line 225: vmDict.remove(vmId); Line 226: log.infoFormat("skipping vm {0} from this monitoring cycle", vmId ); > worth to add the reason we skip will add. I'll change it to DEBUG as well. it shouldn't be an INFO message Line 227: } Line 228: } Line 229: } Line 230: -- To view, visit http://gerrit.ovirt.org/28173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54c6091a3996c23a4b70c7ef89412d34f1b58e34 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
