Daniel Erez has uploaded a new change for review. Change subject: frontend: disk widget - generics in event listeners ......................................................................
frontend: disk widget - generics in event listeners Added proper generics to event listeners to avoid unchecked assignment warnings. Change-Id: I8da8bc74866daf19be16078a7864192c60f3a96d Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java 1 file changed, 16 insertions(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/50/33150/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java index 216167b..30a0e8b 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java @@ -603,9 +603,9 @@ public void edit(final AbstractDiskModel disk) { driver.edit(disk); - disk.getIsAttachDisk().getEntityChangedEvent().addListener(new IEventListener() { + disk.getIsAttachDisk().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { @Override - public void eventRaised(Event ev, Object sender, EventArgs args) { + public void eventRaised(Event<EventArgs> ev, Object sender, EventArgs args) { boolean isAttach = (Boolean) ((EntityModel) sender).getEntity(); createDiskPanel.setVisible(!isAttach); attachDiskPanel.setVisible(isAttach); @@ -617,17 +617,17 @@ } }); - disk.getIsDirectLunDiskAvaialable().getEntityChangedEvent().addListener(new IEventListener() { + disk.getIsDirectLunDiskAvaialable().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { @Override - public void eventRaised(Event ev, Object sender, EventArgs args) { + public void eventRaised(Event<EventArgs> ev, Object sender, EventArgs args) { boolean isDirectLunDiskAvaialable = (Boolean) ((EntityModel) sender).getEntity(); externalDiskPanel.setVisible(isDirectLunDiskAvaialable); } }); - disk.getIsVirtioScsiEnabled().getEntityChangedEvent().addListener(new IEventListener() { + disk.getIsVirtioScsiEnabled().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { @Override - public void eventRaised(Event ev, Object sender, EventArgs args) { + public void eventRaised(Event<EventArgs> ev, Object sender, EventArgs args) { if (disk.getVm() == null) { // not relevant for floating disks return; @@ -693,25 +693,25 @@ storageModel.setHost(disk.getHost()); // SelectedItemChangedEvent handlers - disk.getStorageType().getSelectedItemChangedEvent().addListener(new IEventListener() { + disk.getStorageType().getSelectedItemChangedEvent().addListener(new IEventListener<EventArgs>() { @Override - public void eventRaised(Event ev, Object sender, EventArgs args) { + public void eventRaised(Event<EventArgs> ev, Object sender, EventArgs args) { revealStorageView(disk); } }); - disk.getHost().getSelectedItemChangedEvent().addListener(new IEventListener() { + disk.getHost().getSelectedItemChangedEvent().addListener(new IEventListener<EventArgs>() { @Override - public void eventRaised(Event ev, Object sender, EventArgs args) { + public void eventRaised(Event<EventArgs> ev, Object sender, EventArgs args) { revealStorageView(disk); } }); // Add event handlers - disk.getPropertyChangedEvent().addListener(new IEventListener() { + disk.getPropertyChangedEvent().addListener(new IEventListener<PropertyChangedEventArgs>() { @Override - public void eventRaised(Event ev, Object sender, EventArgs args) { - String propName = ((PropertyChangedEventArgs) args).propertyName; + public void eventRaised(Event<PropertyChangedEventArgs> ev, Object sender, PropertyChangedEventArgs args) { + String propName = args.propertyName; if (propName.equals("IsValid")) { //$NON-NLS-1$ if (disk.getIsValid()) { innerAttachDiskPanel.markAsValid(); @@ -786,11 +786,10 @@ return storageView != null && storageView.isSubViewFocused(); } - final IEventListener progressEventHandler = new IEventListener() { + final IEventListener<PropertyChangedEventArgs> progressEventHandler = new IEventListener<PropertyChangedEventArgs>() { @Override - public void eventRaised(Event ev, Object sender, EventArgs args) { - PropertyChangedEventArgs pcArgs = (PropertyChangedEventArgs) args; - if (PropertyChangedEventArgs.PROGRESS.equals(pcArgs.propertyName)) { + public void eventRaised(Event<PropertyChangedEventArgs> ev, Object sender, PropertyChangedEventArgs args) { + if (PropertyChangedEventArgs.PROGRESS.equals(args.propertyName)) { externalDiskPanel.clear(); if (sanStorageModel.getProgress() != null) { externalDiskPanel.add(progressContent); -- To view, visit http://gerrit.ovirt.org/33150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8da8bc74866daf19be16078a7864192c60f3a96d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
