Roy Golan has posted comments on this change. Change subject: engine: NUMA feature transaction support ......................................................................
Patch Set 7: (1 comment) @Gilad where's the flag? http://gerrit.ovirt.org/#/c/28241/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 269: public Void runInTransaction() { Line 270: addPermission(); Line 271: addVmTemplateImages(srcDeviceIdToTargetDeviceIdMapping); Line 272: addVmInterfaces(srcDeviceIdToTargetDeviceIdMapping); Line 273: addVmNumaNodes(); I think this should be below in the isVmInDb section otherwise the underliyng numa call will fail on canDo vm not exist no? Line 274: if (isVmInDb) { Line 275: VmDeviceUtils.copyVmDevices(getVmId(), Line 276: getVmTemplateId(), Line 277: srcDeviceIdToTargetDeviceIdMapping, -- To view, visit http://gerrit.ovirt.org/28241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84e59fa38c9174fe7150116bf3c8832f7fac1dd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jason Liao <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
