Tal Nisan has uploaded a new change for review. Change subject: core: Update AddStorageDomainCommonTest to succeed when storage pool is null ......................................................................
core: Update AddStorageDomainCommonTest to succeed when storage pool is null Change-Id: I5ba3a0f2c7c08c1592a5791784ca5023b61a156f Signed-off-by: Tal Nisan <[email protected]> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java 1 file changed, 2 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/33173/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java index 96f669d..0df200d 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java @@ -158,11 +158,10 @@ } @Test - public void canDoActionFailsNoPool() { + public void canDoActionSucceedsNoPool() { sd.setStorageFormat(null); vds.setStoragePoolId(null); - CanDoActionTestUtils.runAndAssertCanDoActionFailure - (cmd, VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST); + CanDoActionTestUtils.runAndAssertCanDoActionSuccess(cmd); } @Test @@ -186,13 +185,6 @@ sd.setStorageDomainType(StorageDomainType.Master); CanDoActionTestUtils.runAndAssertCanDoActionFailure (cmd, VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL); - } - - @Test - public void canDoActionFailsNoStoragePool() { - when(spDao.get(spId)).thenReturn(null); - CanDoActionTestUtils.runAndAssertCanDoActionFailure - (cmd, VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST); } @Test -- To view, visit http://gerrit.ovirt.org/33173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ba3a0f2c7c08c1592a5791784ca5023b61a156f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
