Juan Hernandez has uploaded a new change for review.

Change subject: core: Use enum name to search providers
......................................................................

core: Use enum name to search providers

Currently we build search queries for providers using the numeric value
of the type, and comparing it to the "providers.provider_type" database
column. But this column stores the name of the enum, not the numeric
value. This patch changes the autocompleter so that it uses the name.

Change-Id: I4822be2cfd57c093d4fdf11f0410c055faea8be2
Bug-Url: https://bugzilla.redhat.com/1145247
Signed-off-by: Juan Hernandez <[email protected]>
---
M 
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ProviderConditionFieldAutoCompleter.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/15/33215/1

diff --git 
a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ProviderConditionFieldAutoCompleter.java
 
b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ProviderConditionFieldAutoCompleter.java
index 9c55729..d69d24a 100644
--- 
a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ProviderConditionFieldAutoCompleter.java
+++ 
b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ProviderConditionFieldAutoCompleter.java
@@ -43,7 +43,7 @@
     @Override
     public IConditionValueAutoCompleter getFieldValueAutoCompleter(String 
fieldName) {
         if (TYPE.equals(fieldName)) {
-            return new EnumValueAutoCompleter(ProviderType.class);
+            return new EnumNameAutoCompleter(ProviderType.class);
         }
         return null;
     }


-- 
To view, visit http://gerrit.ovirt.org/33215
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4822be2cfd57c093d4fdf11f0410c055faea8be2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to