Daniel Erez has posted comments on this change. Change subject: webadmin: Adding support to import GlusterFS ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/33211/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 675: Task.create(this, Line 676: new ArrayList<Object>(Arrays.asList(new Object[] { "ImportFile", //$NON-NLS-1$ Line 677: host.getId(), localModel.getPath().getEntity(), localModel.getRole(), StorageType.LOCALFS, model.getActivateDomain().getEntity() }))).run(); Line 678: } Line 679: else if (model.getSelectedItem() instanceof GlusterStorageModel) formatter - '{' at EOL Line 680: { Line 681: GlusterStorageModel glusterModel = (GlusterStorageModel) model.getSelectedItem(); Line 682: glusterModel.setMessage(null); Line 683: Line 2047: tempVar.setMountOptions(posixModel.getMountOptions().getEntity()); Line 2048: } Line 2049: if (storageModel instanceof GlusterStorageModel) { Line 2050: GlusterStorageModel glusterModel = (GlusterStorageModel) storageModel; Line 2051: tempVar.setVfsType(glusterModel.getVfsType().getEntity()); please rename 'tempVar' Line 2052: tempVar.setMountOptions(glusterModel.getMountOptions().getEntity()); Line 2053: } Line 2054: storageListModel.fileConnection = tempVar; Line 2055: storageListModel.importFileStorageConnect(); -- To view, visit http://gerrit.ovirt.org/33211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic66b535004d40f28c4b703f5d5899253cd2616ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
