Douglas Schilling Landgraf has posted comments on this change. Change subject: persist.py: use persist from utils when possible ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33090/3/src/plugins/ovirt-host-deploy/node/persist.py File src/plugins/ovirt-host-deploy/node/persist.py: Line 65: [odeploycons.FileLocations.VDSM_ID_FILE] + Line 66: self.environment[otopicons.CoreEnv.MODIFIED_FILES] Line 67: ): Line 68: self.logger.debug('persisting: %s' % f) Line 69: self._persist(f) > hmmm... this will attempt to import every time... the previous was better, Yep, agreed. Previous seems better. Line 70: Line 71: -- To view, visit http://gerrit.ovirt.org/33090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b24131bbddbcc0df9454cc617620cd9aff09c8d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
