Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: config engine to access reports ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/33148/6/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py: Line 65 Line 66 Line 67 Line 68 Line 69 This failed because I moved this code to run at customization, and the jasper war is still not created at this point - and when it's created, its transaction prepare moves it, and therefore commit fails. This was a potential bug even without this change, because it was not explicitly scheduled to run after deply. Even then not sure it would have always worked. I decided it's best to simply copy during deploy and not use filetransaction. -- To view, visit http://gerrit.ovirt.org/33148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b7ea55fc0c8204a88edf39c055c2bb2d53d6dde Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
