Roy Golan has posted comments on this change. Change subject: core: Fixed log for cluster unsupported emulated machine ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32900/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java: Line 56: Line 57: Map<String, String> customLogValues = new HashMap<>(); Line 58: customLogValues.put("hostSupportedEmulatedMachines", vds.getSupportedEmulatedMachines()); Line 59: if(vdsGroup.isDetectEmulatedMachine()) { Line 60: customLogValues.put("clusterEmulatedMachines", Config.<List<String>>getValue(ConfigValues.ClusterEmulatedMachines, vds.getVdsGroupCompatibilityVersion().getValue()).toString()); here the values to show are the Config Values and not cluster emulated machine values it would be nice if the audit log could reflect that. Your call guys if to go for it Line 61: vdsNonOperational(vds, NonOperationalReason.EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER_LEVEL, customLogValues); Line 62: } else { Line 63: customLogValues.put("clusterEmulatedMachines", vdsGroup.getEmulatedMachine()); Line 64: vdsNonOperational(vds, NonOperationalReason.EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER, customLogValues); -- To view, visit http://gerrit.ovirt.org/32900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8397cd64364c98aa76818613dbe78ddef2391027 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
