Yair Zaslavsky has posted comments on this change. Change subject: core: Allow task handlers to drive CommandExecutor commands ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33002/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 93: log.errorFormat("Error invoking callback method {0} for {1} command {2}", Line 94: getCallBackMethod(status), Line 95: status.toString(), Line 96: cmdId.toString()); Line 97: log.error(ex, ex); I would prefer , as in other places in engine have log.debug("",ex); We should not print the stacktrace, but have a meaningful error, if possible (in the log, that is). Line 98: if (!CommandStatus.FAILED.equals(status)) { Line 99: coco.updateCommandStatus(cmdId, CommandStatus.FAILED); Line 100: coco.retrieveCommand(cmdId).getParameters().setTaskGroupSuccess(false); Line 101: } -- To view, visit http://gerrit.ovirt.org/33002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85f54aea19774f86fd92a4a299e5f806943aa480 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
