Roy Golan has posted comments on this change. Change subject: engine: don't allow to create VM with balloon on ppc64 ......................................................................
Patch Set 4: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/32228/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java: Line 119: } Line 120: Line 121: @Test Line 122: public void refuseBalloonOnPPC() { Line 123: final ImportVmCommand<ImportVmParameters> c = setupDiskSpaceTest(0); problem with the argument passed to setupDiskSpaceTest Line 124: c.getParameters().getVm().setBalloonEnabled(true); Line 125: c.getParameters().getVm().setClusterArch(ArchitectureType.ppc64); Line 126: VDSGroup cluster = new VDSGroup(); Line 127: cluster.setArchitecture(ArchitectureType.ppc64); Line 135: } Line 136: Line 137: @Test Line 138: public void acceptBalloon() { Line 139: final ImportVmCommand<ImportVmParameters> c = setupDiskSpaceTest(0); problem with the argument passed to setupDiskSpaceTest Line 140: c.getParameters().getVm().setBalloonEnabled(true); Line 141: c.getParameters().getVm().setClusterArch(ArchitectureType.x86_64); Line 142: VDSGroup cluster = new VDSGroup(); Line 143: cluster.setArchitecture(ArchitectureType.x86_64); -- To view, visit http://gerrit.ovirt.org/32228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
