Liron Aravot has posted comments on this change. Change subject: core: adding RetrieveImageDataCommand ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/32545/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataCommand.java: Line 5: import org.ovirt.engine.core.common.vdscommands.ImageHttpAccessVDSCommandParameters; Line 6: import org.ovirt.engine.core.common.vdscommands.VDSCommandType; Line 7: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue; Line 8: Line 9: public class RetrieveImageDataCommand<T extends RetrieveImageDataParameters> extends SpmCommand<T> { > Shouldn't this be annotated with @InternalAction ? Done Line 10: Line 11: public RetrieveImageDataCommand(T parameters, CommandContext cmdContext) { Line 12: super(parameters, cmdContext); Line 13: } http://gerrit.ovirt.org/#/c/32545/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataParameters.java: Line 9: public RetrieveImageDataParameters(Guid storagePoolId, Line 10: Guid storageDomainId, Line 11: Guid imageGroupId, Line 12: Guid imageId, Line 13: Long length) { > why use java.lang.Long and not a primitive long? basically it was done for future usecases and to prevent the unneeded casts. Line 14: super(imageId); Line 15: this.length = length; Line 16: setStoragePoolId(storagePoolId); Line 17: setStorageDomainId(storageDomainId); -- To view, visit http://gerrit.ovirt.org/32545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ed10f1d3fc74e1deb6c69fc826f02abfd5d679e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
