Allon Mureinik has posted comments on this change. Change subject: core: ImportVMTemplateCommand storage allocation ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Pending review from a virt stakeholder. http://gerrit.ovirt.org/#/c/33044/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java: Line 54: Line 55: @Test Line 56: public void insufficientDiskSpace() { Line 57: //The following is enough since the validation is mocked out anyway. Just want to make sure the flow in CDA is correct. Line 58: //Full test for the scenarios is done in the inherited class. Formatting - add a whitespace after // Line 59: final ImportVmTemplateCommand command = setupVolumeFormatAndTypeTest(VolumeFormat.RAW, VolumeType.Preallocated, StorageType.NFS); Line 60: doReturn(false).when(command).validateSpaceRequirements(anyList()); Line 61: assertFalse(command.canDoAction()); Line 62: } -- To view, visit http://gerrit.ovirt.org/33044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ffc5c00905bb03c9cb3cbffa481e78c9b0ab87a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
