Martin Peřina has posted comments on this change. Change subject: node: support plugin features instead by version ......................................................................
Patch Set 2: Code-Review+1 Verified+1 (1 comment) Verified with ovirt-node-iso-3.5.0.ovirt35.20140912, which was updated with ovirt-host-deploy with this patch and ovirt-node-plugin-vdsm with add feature patch. If kdump is in FEATURES, then it's enabled during host deploy, otherwise it's disabled. http://gerrit.ovirt.org/#/c/33069/2/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 131: ) Line 132: ) Line 133: Line 134: def _kexec_tools_version_supported(self): Line 135: from rpmUtils.miscutils import compareEVR We can move the import into else block as we no longer need it for node ... Line 136: result = False Line 137: Line 138: if self.environment[odeploycons.VdsmEnv.OVIRT_NODE]: Line 139: # on node check ovirt-node-plugin-vdsm features -- To view, visit http://gerrit.ovirt.org/33069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60647e0e51670ea58b3313e5e7b06e8ecf63dffe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
