Juan Hernandez has posted comments on this change.
Change subject: core: Add BLOB servlet
......................................................................
Patch Set 3: (2 inline comments)
Thanks for your comments Grant! See my responses inside.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/blob/BlobRegistry.java
Line 52: BlobServer server = serverReference.get();
As you said in general the main advantage of AtomicReference is the getAndSet
method (and other similar ones) as they help preventing races and unexpected
results. I this case I am using it just to make sure that both threads see the
updated value. But as I said before this is extremely unlikely to happen. Do
you think that we should change it to a plain reference? I mean something like:
private BlobServer server;
Or maybe:
private volatile BlobServer server;
Both will work fine in our use case.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/blob/BlobServlet.java
Line 102: public URL registerBlob (File blob) {
Ok, I will work on that direction.
--
To view, visit http://gerrit.ovirt.org/6484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4726aa4084ebb8f93caf0616aceab10957c16b90
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Grant Murphy <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
