Allon Mureinik has posted comments on this change. Change subject: vdsbroker: no spm failover on attach iso domain failure ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33290/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java: Line 22: @Override Line 23: protected VDSExceptionBase createDefaultConcreteException(String errorMessage) { Line 24: StorageDomain domainFromDb = DbFacade.getInstance().getStorageDomainDao().get(getParameters().getStorageDomainId()); Line 25: if (domainFromDb == null || domainFromDb.getStorageDomainType() == StorageDomainType.ImportExport Line 26: || domainFromDb.getStorageDomainType() == StorageDomainType.ISO) { why not just "!domainFromDb.getStorageDomainType().isData()" ? Line 27: return new IrsOperationFailedNoFailoverException(errorMessage); Line 28: } Line 29: return super.createDefaultConcreteException(errorMessage); Line 30: } -- To view, visit http://gerrit.ovirt.org/33290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93500e5493b7e963c3b218520e5f6e7b96e3fe5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
