Omer Frenkel has posted comments on this change. Change subject: engine: Edit Pool shows different RAM than defined (#833829) ......................................................................
Patch Set 1: (1 inline comment) minor comment engine side looks ok please run test and verify edit vm and edit pool work while changing cpus and ram .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java Line 264: // no need for DataMember, it's setter and calculated from 2 other fields we dont have DataMemeber anymore, so i think this comment can be deleted at all i guess its here just because it was in VmTemplate. -- To view, visit http://gerrit.ovirt.org/6638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaa1a92f7fe85f9c604da8916be5672d8d5b1e8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
