Nir Soffer has posted comments on this change. Change subject: engine: Send net_ifacename to VDSM when connecting iSCSI server ......................................................................
Patch Set 1: Code-Review-1 (4 comments) -1 to make sure we don't have to support inconsistent names like "netIfacename" in the vdsm side. http://gerrit.ovirt.org/#/c/32383/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java: Line 188: public void setIface(String iface) { Line 189: this.iface = iface; Line 190: } Line 191: Line 192: private String netIfacename; Please use consistent mixedCase names: netIfaceName Line 193: Line 194: public String getNetIfacename() { Line 195: return netIfacename; Line 196: } Line 190: } Line 191: Line 192: private String netIfacename; Line 193: Line 194: public String getNetIfacename() { Please use consistent mixedCase names: getNetIfaceName Line 195: return netIfacename; Line 196: } Line 197: Line 198: public void setNetIfacename(String netIfacename) { Line 194: public String getNetIfacename() { Line 195: return netIfacename; Line 196: } Line 197: Line 198: public void setNetIfacename(String netIfacename) { Please use consistent mixedCase names: setNetIfaceName Line 199: this.netIfacename = netIfacename; Line 200: } Line 201: Line 202: @Override http://gerrit.ovirt.org/#/c/32383/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java: Line 78: con.put("iqn", connection.getiqn(), ""); Line 79: con.put("user", connection.getuser_name(), ""); Line 80: con.put("password", connection.getpassword(), ""); Line 81: con.putIfNotEmpty("ifaceName", connection.getIface()); Line 82: con.putIfNotEmpty("netIfacename", connection.getNetIfacename()); This is not consistent with other argument names. Please use "netIfaceName" for the parameter name. Line 83: Line 84: // storage_pool can be null when discovering iscsi send targets or when connecting Line 85: // through vds which has no storage pool Line 86: if (storagePool == null || Config.<Boolean> getValue(ConfigValues.AdvancedNFSOptionsEnabled, -- To view, visit http://gerrit.ovirt.org/32383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e2f3549fa08741f719eeb8d70209ab298e09da3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
