Vojtech Szocs has posted comments on this change.

Change subject: userportal,webadmin: Error dialogs don't close on enter
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/33219/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ErrorPopupPresenterWidget.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ErrorPopupPresenterWidget.java:

Line 29:         getView().hide();
Line 30:     }
Line 31: 
Line 32:     /**
Line 33:      * Does nothing by default.
Please consider removing this comment, I assume it was copied from 
AbstractPopupPresenterWidget#handleEnterKey method.
Line 34:      */
Line 35:     @Override
Line 36:     protected void handleEnterKey() {
Line 37:         onClose();


-- 
To view, visit http://gerrit.ovirt.org/33219
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefd72a9de81a64fd7f194252abd46a646bdcc6c5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to