Juan Hernandez has posted comments on this change. Change subject: build: ovirt-engine-3.5.0 ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/33084/4/build-tools-root/jboss-modules-maven-plugin/pom.xml File build-tools-root/jboss-modules-maven-plugin/pom.xml: Line 19: Maven Plugin used to generate and attach an artifact containing Line 20: JBoss modules Line 21: </description> Line 22: Line 23: <artifactId>jboss-modules-maven-plugin</artifactId> > ^^ what about this one? Changing this isn't strictly required, as the plugin is within the reactor (within the project) and not an external dependency. However, removing the snapshot suffix doesn't hurt, and it is good practice. Remember that if you remove the -SNAPSHOT prefix, then you should also bump the version number in the 3.6 branch, changing it to 1.2-SNAPSHOT, for example. Line 24: <version>1.1-SNAPSHOT</version> Line 25: <packaging>maven-plugin</packaging> Line 26: Line 27: <dependencies> http://gerrit.ovirt.org/#/c/33084/4/pom.xml File pom.xml: Line 603: automatically executed in the package phase of any project Line 604: that uses the plugin: --> Line 605: <plugin> Line 606: <groupId>org.ovirt.engine</groupId> Line 607: <artifactId>jboss-modules-maven-plugin</artifactId> > ^^ What about this one? Same as in the other comment, changing is not strictly required but good practice. Line 608: <version>1.1-SNAPSHOT</version> Line 609: <executions> Line 610: <execution> Line 611: <phase>package</phase> -- To view, visit http://gerrit.ovirt.org/33084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6ce1d7d5d1afb59e64bc81bd3128c8b2ccb555d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
