mooli tayer has posted comments on this change. Change subject: notifier: add support for snmpv6 in SNMP_MANAGERS. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33441/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java: Line 204: private static class Profile { Line 205: Line 206: private static final Pattern HOST_PATTERN = Pattern.compile( Line 207: "" + Line 208: "((?<host>[^\\[:\\s]+)|(?<ipv6>\\[[^\\]]+\\]))" + // DNS/IPv4/[IPv6]) > I usually prefer \[ and not [[ Right it's better. Line 209: "(:(?<port>[^\\s]*))?" // Port (optional) Line 210: ); Line 211: public List<Host> hosts = new LinkedList<>(); Line 212: public OctetString community; -- To view, visit http://gerrit.ovirt.org/33441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a21038928b7e553feefb9ab7669eac588c1c93c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
